EPMRPP-87396 || Error on extension page (#3639)

reportportal · Nov 13, 2023 · 6cfb0b7 · 6cfb0b7
1 parent 821fa87
commit 6cfb0b7
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 20 deletions.
diff --git a/app/src/components/extensionLoader/hooks.js b/app/src/components/extensionLoader/hooks.js
@@ -28,6 +28,7 @@ const useDynamicScript = (scope, url) => {
     element.onerror = () => {
       setReady(false);
       setFailed(true);
+      element.remove();
     };
 
     document.head.appendChild(element);

diff --git a/app/src/pages/common/uiExtensionPage/uiExtensionPage.jsx b/app/src/pages/common/uiExtensionPage/uiExtensionPage.jsx
@@ -32,26 +32,33 @@ export const UiExtensionPage = ({ extensions, activePluginPage }) => {
 
   const [headerNodes, setHeaderNodes] = useState({});
 
-  const pageLayout =
-    extension && extension.newLayout ? (
-      <>
-        <div className={cx('header')}>
-          <Header titleNode={headerNodes.titleNode} title={extension.title || extension.name}>
-            {headerNodes.children}
-          </Header>
-        </div>
-        <PageSection>
-          <ExtensionLoader extension={extension} withPreloader setHeaderNodes={setHeaderNodes} />
-        </PageSection>
-      </>
-    ) : (
-      <PageLayout>
-        {extension && <PageHeader breadcrumbs={[{ title: extension.title || extension.name }]} />}
-        <PageSection>
-          <ExtensionLoader extension={extension} withPreloader />
-        </PageSection>
-      </PageLayout>
-    );
+  let pageLayout = null;
+
+  if (extension) {
+    if (extension.newLayout) {
+      pageLayout = (
+        <>
+          <div className={cx('header')}>
+            <Header titleNode={headerNodes.titleNode} title={extension.title || extension.name}>
+              {headerNodes.children}
+            </Header>
+          </div>
+          <PageSection>
+            <ExtensionLoader extension={extension} withPreloader setHeaderNodes={setHeaderNodes} />
+          </PageSection>
+        </>
+      );
+    } else {
+      pageLayout = (
+        <PageLayout>
+          <PageHeader breadcrumbs={[{ title: extension.title || extension.name }]} />
+          <PageSection>
+            <ExtensionLoader extension={extension} withPreloader />
+          </PageSection>
+        </PageLayout>
+      );
+    }
+  }
 
   return pageLayout;
 };