Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install: add -DLIBVERSION_STATIC_DEFINE to Cflags in the pkg-config file on Windows. #27

Closed
wants to merge 1 commit into from

Conversation

AndreyMZ
Copy link

@AndreyMZ AndreyMZ commented Mar 6, 2021

Fixes #26.

I have chosen the solution 1, because I don't know how to properly install the DLL, especially using cmake.

@repology repology deleted a comment from codecov-io Mar 6, 2021
@AMDmi3
Copy link
Member

AMDmi3 commented Mar 9, 2021

This doesn't look correct. pkg-config file already contains this define for --static mode:

Cflags.private: -DLIBVERSION_STATIC_DEFINE

Instead, shared library installation should be fixed on windows.

@AndreyMZ
Copy link
Author

pkg-config file already contains this define for --static mode

pkg-config(1) metadata file does not have such keyword: Cflags.private. The command pkg-config --libs --cflags --static libversion outputs the same:

C:\libversion>pkg-config --libs --cflags --static libversion
-IC:/Program\ Files/libversion/include -LC:/Program\ Files/libversion/lib -lversion

This is because the feature request https://gitlab.freedesktop.org/pkg-config/pkg-config/-/issues/38 is not implemented yet.

@AMDmi3
Copy link
Member

AMDmi3 commented Mar 11, 2021

Too bad, pkgconf does support it. Regardless, this is still not a correct fix.

@AMDmi3 AMDmi3 closed this Mar 27, 2021
@AMDmi3
Copy link
Member

AMDmi3 commented Mar 27, 2021

Timeout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors LNK2001 on linking with libversion on Windows [bug]
2 participants