Monitor main_thread in Database/AsyncDatabase to determine whether we need to automatically call close() #214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Especially with
default_db
, it's not clear that the user still needs to callclose()
. Monitor the main thread for termination to do this automatically.What changed
The presumption is that users won't be relying on the database to hold the python runtime open, and that any instance of that is in fact some form of error.
Test plan
confirm that we exit cleanly and quickly.
Rollout
No special instructions.