This repository has been archived by the owner on Jun 23, 2018. It is now read-only.
Added loading scripts without the id set #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| BASE_PATH = script_element.src.split('/')[...-1].join '/' | ||
| SANDBOX_SRC = "#{BASE_PATH}/sandbox.html" | ||
| break | ||
| if BASE_PATH? |
There was a problem hiding this comment.
is that supposed to be not BASE_PATH??
|
Just wondering, why this hasn't been addressed at all since the last update I made? |
|
your pull request is prefaced with "This is untested code!" in bold, and I haven't had time to go in and tested. Will get to it soon |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is untested code!, but it should work.
I don't currently have access to a computer that can fully build jsrepl (the closure compiler with 4G's of ram breaks all of the devices I use).