Joshd/sc 88868/reject requests for vm clusters with 1 nodes #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cli/cmd/cluster_create.go
Outdated
| This is a beta feature, with some known limitations: | ||
| - K3s, Kind, kurl, helmvm and Openshift clusters only support a single node. | ||
| - EKS clusters may report ready before the nodes are completely online. | ||
| - kurl is the only supported distribution that can be upgraded. |
There was a problem hiding this comment.
this line should be a limitation of the cluster upgrade command, not cluster create
There was a problem hiding this comment.
I think it's a fair warning here so it's not a surprise later. Maybe wording can be improved.
divolgin
reviewed
Sep 15, 2023
pkg/kotsclient/cluster_upgrade.go
Outdated
| return nil, ve, nil | ||
| // if err is APIError and the status code is 400, then we have a validation error | ||
| // and we can return the validation error | ||
| if apiErr, ok := err.(platformclient.APIError); ok { |
There was a problem hiding this comment.
errors.Cause(err).(platformclient.APIError)
divolgin
reviewed
Sep 15, 2023
cli/cmd/cluster_create.go
Outdated
| } | ||
| return nil, fmt.Errorf("%s", errors.New(strings.Join(ve.Errors, ","))) | ||
| return nil, fmt.Errorf("%s", ve.Message) |
divolgin
previously approved these changes
Sep 15, 2023
divolgin
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next to doing a validation on number of nodes, it also fixes some other issues.
https://www.loom.com/share/cd576538ffa44be8a538f11c46d8b9df?sid=0839438f-8349-4a9e-8b92-cd92b5932f3a