Add TLS 1.2 support via configuration #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
N.B.: This PR is combined is meant to be reviewed alongside #91
This PR adds a TLS 1.2 override to
ClientConfig. This is useful in cases where we want to use a signing scheme that is not supported by TLS 1.3.Resolves # (issue) N/A
How Has This Been Tested?
I've pulled my fork into our own internal codebase and tested this by signing using RSA
PKCS1v15signing scheme, something that is NOT supported by TLS 1.3 for client auth. Got push notifications successfully sending to my device!*Writing a unit test is fairly difficult here, so please let me know if you'd like me to add toexamples/certificate_client.rsDue Dilligence