feat(pip-compile): support tool version constraints with uv #34029
+147
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
rarkins
reviewed
Feb 4, 2025
| if (compileArgs.commandType === 'uv') { | ||
| pythonVersion = compileArgs.pythonVersion; | ||
| } else { | ||
| pythonVersion = extractPythonVersion(existingOutput, outputFileName); |
There was a problem hiding this comment.
Shouldn't you still fall back to this if python version is missing from the args?
There was a problem hiding this comment.
That would not be useful since uv does not write the Python version to the header. If the user does not specify the version with --python-version, uv's behavior is to use the latest version available in the environment
There was a problem hiding this comment.
does it prefer config constraints from user config?
There was a problem hiding this comment.
@viceice can you clarify what you mean by that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
--python-versionflaguvtool constraint from configContext
Follow up to #33952 (comment)
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: