Rewrite termination measures sooner #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This used to happen after parsing, but now happens later in a rewrite. However, if it happens after other rewrites that rename variables, the measures might no longer type-check, so perform the measure rewrite as soon as possible.
Also adds a simple function call graph that is only function calls, doesn't include any other dependencies, and doesn't need a typing.
|
Two issues came up:
|
To ensure that the result will type check, we need to move any valspecs for functions directly used in the measure forward. The definitions themselves will be rearranged later by the sorting rewrite. Note that the type checker will ensure that a valspec always exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This used to happen after parsing, but now happens later in a rewrite. However, if it happens after other rewrites that rename variables, the measures might no longer type-check, so perform the measure rewrite as soon as possible.