fix(create-remix): add fallback git author to initial commit #10115
Conversation
|
|
Hi @klibardi, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
klibardi
force-pushed
the
fix-remix-create-when-no-global-git-config
branch
from
06e9dcd
to
a03f5c5
Compare
…zation step When run in an environment where git global config has not been set via ``` git config --global user.email "[email protected]" git config --global user.name "Your Name" ``` and cannot be inferred from local username and hostname, the initialization process fails (git exits with exit code 128). Setting a default
klibardi
force-pushed
the
fix-remix-create-when-no-global-git-config
branch
from
a03f5c5
to
64b9ac8
Compare
MichaelDeBoey
changed the title
| const commitUser = "create-remix"; | ||
| const commitEmail = "<>" |
There was a problem hiding this comment.
I think this should be the fallback and we should use the available global defaults first
When run in an environment where git global config has not been set via
and cannot be inferred from local username and hostname, the initialization process fails (git exits with exit code 128).
Closes: #
Testing Strategy:
Manual, just tried running it with various git setups.