Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: widen the crossOrigin type in HtmlLinkProps #10069

Conversation

dario-piotrowicz
Copy link
Contributor

Closes: #10068

  • Docs
  • Tests

Testing Strategy:

Copy link

changeset-bot bot commented Oct 6, 2024

⚠️ No Changeset found

Latest commit: 5eb5276

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dario-piotrowicz dario-piotrowicz marked this pull request as draft October 6, 2024 18:07
@dario-piotrowicz
Copy link
Contributor Author

ah 😬

This is not going to work as this is incompatible with the React types now... 😓

Screenshot 2024-10-06 at 19 14 17

@dario-piotrowicz dario-piotrowicz deleted the dario/widen-cross-origin-type branch October 6, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Newly created and built Remix application using the Cloudflare template fail typechecking
1 participant