Skip to content

Commit

Permalink
Merge branch 'dev' into modernize-deno-template
Browse files Browse the repository at this point in the history
  • Loading branch information
redabacha authored Oct 11, 2024
2 parents 62fe2d1 + ed3a99a commit f4a1e48
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions packages/remix-dev/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
### Patch Changes

- Stop passing `request.signal` as the `renderToReadableStream` `signal` to abort server rendering for cloudflare/deno runtimes because by the time that `request` is aborted, aborting the rendering is useless because there's no way for React to flush down the unresolved boundaries ([#10047](https://github.com/remix-run/remix/pull/10047))

- This has been incorrect for some time, but only recently exposed due to a bug in how we were aborting requests when running via `remix vite:dev` because we were incorrectly aborting requests after successful renders - which was causing us to abort a completed React render, and try to close an already closed `ReadableStream`.
- This has likely not shown up in any production scenarios because cloudflare/deno production runtimes are (correctly) not aborting the `request.signal` on successful renders
- The built-in `entry.server` files no longer pass a `signal` to `renderToReadableStream` because adding a timeout-based abort signal to the default behavior would constitute a breaking change
Expand Down

0 comments on commit f4a1e48

Please sign in to comment.