feat: optimize commands for Bun #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brophdawg11
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
I think this is ok for now - but I worry about this expanding in complexity down the road. Hopefully since we don't really plan to add functionality to these stacks it won't be much to change in the future.
Let's be cognizant of a lot of complexity sneaking in the future. If it expands a lot we may be better off just making a bun indie stack instead of trying to fork the internals in here
MichaelDeBoey
force-pushed
the
optimize-commands-for-Bun
branch
from
a420ad4
to
3764059
Compare
|
@brophdawg11 The only thing I'm doing here is dropping usage of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#265 needs to be merged first