Simplify ESLint Config #261
Conversation
| rules: { | ||
| "react/jsx-no-leaked-render": [ | ||
| "warn", | ||
| { validStrategies: ["ternary"] }, | ||
| ], | ||
| }, |
There was a problem hiding this comment.
I could go either way on this one-off rule. On one hand, if we truly want to stay out of the opinion game, then we technically should have zero rules or our own. But this one seems like it solves a common footgun, and TBH I was surprised it wasn't enable din the recommended plugin...so I added it. (It was also one we turned on via eslintrc.repo.js before.
| rules: { | ||
| "import/order": [ | ||
| "error", | ||
| { | ||
| alphabetize: { caseInsensitive: true, order: "asc" }, | ||
| groups: ["builtin", "external", "internal", "parent", "sibling"], | ||
| "newlines-between": "always", | ||
| }, | ||
| ], | ||
| }, |
There was a problem hiding this comment.
Same comment as above. I personally hate lack of consistency when it comes to imports - but again this is veering into "opinion" territory.
.github/workflows/format-repo.yml
Outdated
| @@ -29,7 +29,7 @@ jobs: | |||
| run: npm install | |||
|
|
|||
| - name: 👔 Format | |||
| run: npm run format:repo | |||
| run: npm run format | |||
There was a problem hiding this comment.
We only have one config now so no longer need separate format/format:repo and lint/lint:repo options
app/db.server.ts
Outdated
| // Hard-code a unique key, so we can look up the client when this module gets re-imported | ||
| const prisma = singleton("prisma", () => new PrismaClient()); | ||
| const prisma = remember("prisma", () => new PrismaClient()); |
There was a problem hiding this comment.
singleton had some TS lint errors so I removed it in favor of remember
| @@ -100,6 +100,7 @@ export default function Join() { | |||
| ref={emailRef} | |||
| id="email" | |||
| required | |||
| // eslint-disable-next-line jsx-a11y/no-autofocus | |||
| autoFocus={true} | |||
There was a problem hiding this comment.
These feel like they're an OK exception to the rule as this form is the sole purpose of the page
| @@ -1,6 +1,7 @@ | |||
| import { faker } from "@faker-js/faker"; | |||
|
|
|||
| declare global { | |||
| // eslint-disable-next-line @typescript-eslint/no-namespace | |||
There was a problem hiding this comment.
I didn't know the best way to do this otherwise so I just disabled it.
This is the first step towards deprecating the
@remix-run/eslint-configpackage as outlined in remix-run/remix#7056.Remix doesn't need to be in the business of providing opinions on how teams lint their Remix app code - that should be a team decision. The stacks can and should provide a working ESLint setup that teams can tweak to their liking. So this PR removes the
@remix-run/eslint-configdependency and simplifies the config to a single-file that just relies on industry "recommended" plugins for technologies used by the stacks (react, TS, vitest, cypress, etc.).