Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add ALU design #72

Merged
merged 22 commits into from
Oct 18, 2024
Merged

docs: add ALU design #72

merged 22 commits into from
Oct 18, 2024

Conversation

wzmuda
Copy link
Contributor

@wzmuda wzmuda commented Oct 7, 2024

Summary

This document captures research done in #27. Mostly, it's just the contents of my lengthy comment from that issue, corrected after Ara's comments. I also added a section on the statefulness (or the lack thereof). It's based on what we've discussed with Ara in the task comments and privately and my research mostly based on LLVM Language Reference Manual and some experiments with Godbolt generating IR from Rust. Also The Rust Book and The Cairo Book.

Details

I still use the word intrinsic everywhere because I think it's correct usage., but I'm still open for debate. Maybe I don't understand something.

Checklist

  • [ ] Code is formatted by Rustfmt.
  • Documentation has been updated if necessary.

@wzmuda wzmuda requested a review from a team as a code owner October 7, 2024 22:36
@wzmuda wzmuda marked this pull request as draft October 7, 2024 23:39
@wzmuda
Copy link
Contributor Author

wzmuda commented Oct 7, 2024

The document has too little of the actual design, so a detailed list of functions to implement will follow, as well as a chapter on data types, which is another point of data as for which operations need to be implemented and which are not.

@wzmuda wzmuda force-pushed the wz/alu-design branch 2 times, most recently from 14dd236 to 1d0ecdc Compare October 10, 2024 21:46
This document captures research done in #27.

Signed-off-by: Wojciech Zmuda <[email protected]>
@wzmuda wzmuda marked this pull request as ready for review October 14, 2024 20:43
Copy link
Collaborator

@iamrecursion iamrecursion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! I've added some comments, wording tweaks and questions inline that I'd like to see addressed before we merge!

docs/ALU Design.md Outdated Show resolved Hide resolved
docs/ALU Design.md Outdated Show resolved Hide resolved
docs/ALU Design.md Outdated Show resolved Hide resolved
docs/ALU Design.md Outdated Show resolved Hide resolved
docs/ALU Design.md Show resolved Hide resolved
docs/ALU Design.md Outdated Show resolved Hide resolved
docs/ALU Design.md Outdated Show resolved Hide resolved
docs/ALU Design.md Outdated Show resolved Hide resolved
docs/ALU Design.md Outdated Show resolved Hide resolved
docs/ALU Design.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@iamrecursion iamrecursion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more things I think we need to establish

docs/ALU Design.md Outdated Show resolved Hide resolved
docs/ALU Design.md Outdated Show resolved Hide resolved
docs/ALU Design.md Show resolved Hide resolved
docs/ALU Design.md Outdated Show resolved Hide resolved
docs/ALU Design.md Outdated Show resolved Hide resolved
docs/ALU Design.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@iamrecursion iamrecursion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Just a couple of minor grammar/formatting things in there.

docs/ALU Design.md Outdated Show resolved Hide resolved
docs/ALU Design.md Outdated Show resolved Hide resolved
@wzmuda wzmuda merged commit 10081aa into main Oct 18, 2024
4 checks passed
@wzmuda wzmuda deleted the wz/alu-design branch October 18, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants