-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add ALU design #72
Conversation
The document has too little of the actual design, so a detailed list of functions to implement will follow, as well as a chapter on data types, which is another point of data as for which operations need to be implemented and which are not. |
14dd236
to
1d0ecdc
Compare
This document captures research done in #27. Signed-off-by: Wojciech Zmuda <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! I've added some comments, wording tweaks and questions inline that I'd like to see addressed before we merge!
Co-authored-by: Ara Adkins <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more things I think we need to establish
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome! Just a couple of minor grammar/formatting things in there.
Co-authored-by: Ara Adkins <[email protected]>
Summary
This document captures research done in #27.
Mostly, it's just the contents of my lengthy comment from that issue, corrected after Ara's comments. I also added a section on the statefulness (or the lack thereof).It's based on what we've discussed with Ara in the task comments and privately and my research mostly based on LLVM Language Reference Manual and some experiments with Godbolt generating IR from Rust. Also The Rust Book and The Cairo Book.Details
I still use the word intrinsic everywhere because I think it's correct usage., but I'm still open for debate. Maybe I don't understand something.
Checklist
[ ] Code is formatted by Rustfmt.