Make the nix stuff work reliably #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wzmuda
reviewed
Oct 2, 2024
This fixes some commands that were depending on things being in the system path and not provided by the nix development environment. It also makes the precommit hooks more efficient, now only ever running on changed files as needed.
iamrecursion
force-pushed
the
wip/ara/fix-nix-build
branch
from
f18d664 to
f882157
Compare
wzmuda
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes some commands that were depending on things being in the system path and not provided by the nix development environment. It also makes the precommit hooks more efficient, now only ever running on changed files as needed.
Details
As long as CI passes this should be good.
Checklist