[WIP] -netthread fixes and implementation for linux
#569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In-line
changed the title
In-line
force-pushed
the
NetThreadLinux
branch
7 times, most recently
from
1f35cf0
to
48be56d
Compare
In-line
changed the title
In-line
changed the title
|
After several tests was confirmed that -netthread is not stable for now. Ping can increase 100+ at random time. |
|
It was tested by several people at least nothing bad was reported for the time going. |
In-line
changed the title
In-line
force-pushed
the
NetThreadLinux
branch
from
4fce6a1
to
4c97eac
Compare
|
please confirm is it ready and tested? |
|
@theAsmodai Yes, it it ready and was tested by serveral people. |
theAsmodai
reviewed
Feb 13, 2018
| @@ -1198,11 +1235,38 @@ void NET_StopThread() | |||
| { | |||
| if (net_thread_initialized) | |||
| { | |||
| #ifdef REHLDS_FIXES // Safe thread stopping. | |||
| NET_ThreadLock(); | |||
| net_thread_terminated = true; | |||
There was a problem hiding this comment.
You don't need lock here.
There was a problem hiding this comment.
@theAsmodai what's the reason? x86?
|
You can think about this as poor man's |
|
I don't understand you. |
In-line
changed the title
|
@theAsmodai Don't merge this for now. It seems that we need to place memory barriers. https://stackoverflow.com/questions/286629/what-is-a-memory-fence |
|
Here it's not necessary. |
SergeyShorokhov
changed the title
-netthread fixes and implementation for linux
s1lentq
force-pushed
the
master
branch
2 times, most recently
from
43df0ba
to
de3679f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.