Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase engine limits in accordance to the new update #1002

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Increase engine limits in accordance to the new update #1002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
edc78e4
Increase `MAX_PACKET_ENTITES` from 256 to 1024.
fantoro Nov 21, 2023
dc24f5e
Increase `NUM_EDICTS` from 900 to 1200.
fantoro Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rehlds/common/qlimits.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,6 @@ constexpr auto MAX_LIGHTSTYLE_SIZE = size_t{64};
#define MAX_BASE_DECALS (1<<MAX_DECAL_INDEX_BITS)

#define MAX_EVENTS 256
#define MAX_PACKET_ENTITIES 256 // 256 visible entities per frame
Copy link
Member

@SergeyShorokhov SergeyShorokhov Nov 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment, when game clients have not updated and have an old version, this change can be critical and older versions of game clients will get critical errors.

safe point is here
https://github.com/dreamstalker/rehlds/blob/3f19bc1d3e254d9665893e93383487ba03d29f2a/rehlds/engine/sv_main.cpp#L4671-L4675

You can test it with CI binaries:
https://github.com/dreamstalker/rehlds/actions/runs/6957538650

#define MAX_PACKET_ENTITIES 1024 // 1024 visible entities per frame

#endif // QLIMITS_H
2 changes: 1 addition & 1 deletion rehlds/engine/server.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
#include "maintypes.h"

// TODO: I think this defines must be in /common/
const int NUM_EDICTS = 900;
const int NUM_EDICTS = 1200;
const int MAX_NAME = 32;

#include "custom_int.h"
Expand Down
Loading