Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add clean_whitespace option to fuzzy retrieval function #900

Closed
wants to merge 1 commit into from
Closed

add clean_whitespace option to fuzzy retrieval function #900

wants to merge 1 commit into from

Conversation

ryboselm
Copy link

@ryboselm ryboselm commented Apr 8, 2022

do not merge yet, i made this as a starting point for issue 878 (#878), still figuring out what else needs to be modified outside of this one function

@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #900 (2bc57b5) into master (6e06bde) will decrease coverage by 0.05%.
The diff coverage is 64.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #900      +/-   ##
==========================================
- Coverage   71.66%   71.61%   -0.06%     
==========================================
  Files          75       75              
  Lines        8187     8197      +10     
==========================================
+ Hits         5867     5870       +3     
- Misses       2320     2327       +7     
Impacted Files Coverage Δ
regolith/tools.py 82.74% <64.70%> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e06bde...2bc57b5. Read the comment docs.

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before coding the solution, code some tests. You will find the tests for fuzzy_retrieval in tests/test_tools.py. Then code the solution until the tests pass. Add a test for each possible combination.

@ryboselm ryboselm closed this Jun 13, 2022
@ryboselm
Copy link
Author

I don't think the change I made in this commit actually solves anything related to issue #878. closing the PR because of that. will make a new one that actually fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants