Add a simple update #966

isuruf · 2020-04-20T18:18:21Z

No description provided.

codecov · 2020-04-20T18:21:43Z

Codecov Report

Merging #966 into master will decrease coverage by 0.50%.
The diff coverage is 40.54%.

@@            Coverage Diff             @@
##           master     #966      +/-   ##
==========================================
- Coverage   61.66%   61.16%   -0.51%     
==========================================
  Files          43       43              
  Lines        4156     4215      +59     
==========================================
+ Hits         2563     2578      +15     
- Misses       1593     1637      +44

Impacted Files	Coverage Δ
conda_forge_tick/migrators/version.py	`71.63% <40.54%> (-7.64%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a86474c...9559005. Read the comment docs.

conda_forge_tick/migrators/version.py

beckermr · 2020-04-20T18:29:08Z

conda_forge_tick/migrators/version.py

@@ -492,7 +493,69 @@ def migrate(
            attrs["new_version_errors"][version] = _fmt_error_message(errors, version)
            return {}

-        if len(list(_gen_key_selector(cmeta.meta, "source"))) > 0:
+        def _try_simple_update():


Let's make this a full function with inputs etc outside of here. There is a lot of logic and separate tests of it might be useful.

beckermr

Let's add a test recipe that has some recipe that is supposed to be updated by the simpler version and some recipe that is not and make sure the logic in the code that catches errors is doing it's job.

beckermr · 2020-04-20T19:23:41Z

conda_forge_tick/migrators/version.py

+            if source_section.count("url:") != len(sources):
+                return {}, "there are more URLs than expected"
+            if source_section.count(hash_type + ":") != len(sources):
+                return {}, "there are more hashes than expected"


These errors are not quite descriptive.

Add a simple update

81870f8

else if -> elif

34b13ee