Allow migrating compilers using include_build
#2995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckermr
approved these changes
Sep 4, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2995 +/- ##
==========================================
- Coverage 76.12% 76.11% -0.02%
==========================================
Files 115 115
Lines 12261 12263 +2
==========================================
Hits 9334 9334
- Misses 2927 2929 +2 ☔ View full report in Codecov by Sentry. |
|
Thanks for the review |
1 task
ytausch
reviewed
Sep 6, 2024
| @@ -677,7 +678,10 @@ def create_rebuild_graph( | |||
| requirements = attrs.get("requirements", {}) | |||
| host = requirements.get("host", set()) | |||
| build = requirements.get("build", set()) | |||
| bh = host or build | |||
| if include_build: | |||
| bh = host | build | |||
There was a problem hiding this comment.
I think build_host_requirements or similar is a more descriptive variable name than bh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Checklist:
Cross-refs, links to issues, etc: