Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to migration on conda-forge.org in PR description #2992

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

duncanmmacleod
Copy link
Contributor

Description:

This PR modifies the PR description for migrations to include a link to the migration page on conda-forge.org. This may help (will help me) maintainers understand the status of the whole migration and where their package update sits in the grand scheme of things.

Checklist:

  • Pydantic model updated or no update needed

Cross-refs, links to issues, etc:

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.12%. Comparing base (d50acc4) to head (43ecbf7).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2992      +/-   ##
==========================================
+ Coverage   76.09%   76.12%   +0.03%     
==========================================
  Files         115      115              
  Lines       12259    12261       +2     
==========================================
+ Hits         9328     9334       +6     
+ Misses       2931     2927       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! We need one change which you would have had no way of knowing about. :(

conda_forge_tick/migrators/migration_yaml.py Outdated Show resolved Hide resolved
Copy link
Contributor

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@beckermr beckermr enabled auto-merge September 4, 2024 12:06
@beckermr beckermr added this pull request to the merge queue Sep 4, 2024
Merged via the queue into regro:main with commit 7455714 Sep 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants