-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't consider build reqs for cross compiling platforms #1313
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1313 +/- ##
==========================================
- Coverage 57.54% 57.52% -0.02%
==========================================
Files 66 66
Lines 6468 6470 +2
==========================================
Hits 3722 3722
- Misses 2746 2748 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the right spot to make this change. We want the parsed recipes to be accurate, but we want to clip edges when making the graphs for migrations.
I'd check out the code sections around here: https://github.com/regro/cf-scripts/blob/master/conda_forge_tick/migrators/arch.py#L198 It looks like the migrator itself is adding edges from build deps. Maybe remove those bits. |
This is not for the osx arm migrator. It's for other migrators like |
My same comment still applies. The node attributes need to be correct and we need to handle this elsewhere. The code that makes the graph for ABI builds is here: https://github.com/regro/cf-scripts/blob/master/conda_forge_tick/migrators/migration_yaml.py#L466 It uses |
Also we should make sure to handle the case if we have native builds for osx-arm64 too. |
No description provided.