Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't consider build reqs for cross compiling platforms #1313

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Nov 26, 2020

No description provided.

@codecov
Copy link

codecov bot commented Nov 26, 2020

Codecov Report

Merging #1313 (a3bc338) into master (fed1f78) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1313      +/-   ##
==========================================
- Coverage   57.54%   57.52%   -0.02%     
==========================================
  Files          66       66              
  Lines        6468     6470       +2     
==========================================
  Hits         3722     3722              
- Misses       2746     2748       +2     
Impacted Files Coverage Δ
conda_forge_tick/feedstock_parser.py 59.42% <0.00%> (-0.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fed1f78...a3bc338. Read the comment docs.

Copy link
Contributor

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the right spot to make this change. We want the parsed recipes to be accurate, but we want to clip edges when making the graphs for migrations.

@beckermr
Copy link
Contributor

I'd check out the code sections around here: https://github.com/regro/cf-scripts/blob/master/conda_forge_tick/migrators/arch.py#L198

It looks like the migrator itself is adding edges from build deps. Maybe remove those bits.

@isuruf
Copy link
Member Author

isuruf commented Nov 26, 2020

This is not for the osx arm migrator. It's for other migrators like libffi33

@beckermr
Copy link
Contributor

My same comment still applies. The node attributes need to be correct and we need to handle this elsewhere.

The code that makes the graph for ABI builds is here: https://github.com/regro/cf-scripts/blob/master/conda_forge_tick/migrators/migration_yaml.py#L466

It uses build or host to make the bot robust to conda-build 2 formatted recipes. We'll have to condition this on which platform is being done or something.

@beckermr
Copy link
Contributor

Also we should make sure to handle the case if we have native builds for osx-arm64 too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants