Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Refactor Requester modules #371

Open
wants to merge 40 commits into
base: develop
Choose a base branch
from

Conversation

JBetz
Copy link
Contributor

@JBetz JBetz commented Dec 11, 2019

Refactor and cleanup, also confirmed to fix at least one bug in Adjustable (#369).

(result0, requests0) <- lift $ runA a0
newA <- requestingIdentity $ runA <$> a'
requests <- switchHoldPromptOnly requests0 $ fmapCheap snd newA
--TODO: promptly *prevent* events, then sign up the new ones; this is a serious breaking change to PerformEvent
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to call this out so we don't neglect it in review and testing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This same comment appears in a few places.

@lpsmith lpsmith added breaking change bug fix clean up Removes stale code, improves read-ability, or small refactors labels Dec 20, 2019
@JBetz JBetz force-pushed the requester-simple-fix-nonempty-deferred branch from 442826d to aa51587 Compare January 16, 2020 20:30
@JBetz JBetz force-pushed the requester-simple-fix-nonempty-deferred branch from aa51587 to bcf920c Compare January 16, 2020 20:31
@414owen 414owen force-pushed the requester-simple-fix-nonempty-deferred branch from 6904992 to d2d152d Compare April 7, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change bug fix clean up Removes stale code, improves read-ability, or small refactors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants