Docs: Clarify Netlify build and deployment and advise not to use the Netlify CLI #6261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportWe didn't find any information for the current pull request with the commit f306266. Check the Nx Cloud Github Integration documentation for more information. Sent with 💌 from NxCloud. |
✅ Deploy Preview for redwoodjs-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ericapisani
reviewed
Aug 22, 2022
Co-authored-by: Erica Pisani <[email protected]>
Co-authored-by: Erica Pisani <[email protected]>
Co-authored-by: Erica Pisani <[email protected]>
|
@ericapisani Thanks. I am the king of typos. |
ericapisani
approved these changes
Aug 22, 2022
Tobbe
reviewed
Aug 22, 2022
Co-authored-by: Tobbe Lundberg <[email protected]>
Co-authored-by: Tobbe Lundberg <[email protected]>
Co-authored-by: Tobbe Lundberg <[email protected]>
Tobbe
reviewed
Aug 22, 2022
Tobbe
approved these changes
Aug 25, 2022
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Aug 25, 2022
…-performance * 'main' of github.com:redwoodjs/redwood: Docs: Clarify Netlify build and deployment and advise not to use the Netlify CLI (redwoodjs#6261) fix(deps): update dependency eslint-plugin-react to v7.31.0 (redwoodjs#6289) fix(deps): update graphql-tools monorepo (redwoodjs#6285) fix(deps): update graphqlcodegenerator monorepo (redwoodjs#6286) fix(deps): update dependency core-js to v3.25.0 (redwoodjs#6287) chore(deps): update dependency firebase to v9.9.3 (redwoodjs#6258) fix: `import/order` should treat "glob star" imports as their own group (redwoodjs#6213) install emotion react w/ mantine packages (redwoodjs#6257) feat(ts): Improve types for directives (redwoodjs#6272)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6260
There has been some confusion in Discord where some people were trying to build and deploy a redwoodJS app to Netlofy using Netlify's CLI and the build and deploy commands.
These commands with build the RedwoodJS locally (using the local settings and local OS) and then deploy the dist.
Problems arise with some package locations and how the list in bundled ... but the biggest issue is that the Prisma client will build using Windows or OSX and Netlfiy deploys need a linux variant.
So, the Prisma client that gets deployed is incompatible and fails.
Therefore, documentation needs to advise against using the Netlify and use the approach already documented in:
Updates docs here: redwoodjs.com/docs/tutorial/chapter4/deployment#netlify and in the deploy and cli command.
Also, adds a note in the yarn rw setup deploy netlify command.
Note: I looked for a way to include markdown snippets since the copy is essentially the same and would be nicer to include the cautionary admonition to keep the copy consistent and easier to edit. I didn't see a way immediately, but would much rather do that if possible./