Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]: Clarify Netlify deployment should use the providers build and deploy flow, and not the "netlify cli" local #6260

Closed
1 task done
dthyresson opened this issue Aug 22, 2022 · 1 comment · Fixed by #6261
Assignees

Comments

@dthyresson
Copy link
Contributor

Summary and description

See docs here: https://redwoodjs.com/docs/tutorial/chapter4/deployment#netlify

There has been some confusion in Discord where some people were trying to build and deploy a redwoodJS app to Netlofy using Netlify's CLI and the build and deploy commands.

These commands with build the RedwoodJS locally (using the local settings and local OS) and then deploy the dist.

Problems arise with some package locations and how the list in bundled ... but the biggest issue is that the Prisma client will build using Windows or OSX and Netlfiy deploys need a linux variant.

So, the Prisma client that gets deployed is incompatible and fails.

Therefore, documentation needs to advise against using the Netlify and use the approach already documented in:

See docs here: https://redwoodjs.com/docs/tutorial/chapter4/deployment#netlify

Also, add a note in the yarn rw setup deploy netlify command.

Are you interested in working on this?

  • I'm interested in working on this
@Gresliebear
Copy link

I completely agree!!! I have been using Netlify CLI for 2 weeks as deployment tool that fails I recreated it as a public issue Gresliebear/TestingRedwoodDeployment#3 here don't make the same mistake!!! I wasted weeks of my life!!!

Will there be a future long-term solution until a fixed is made? I don't know I will post a solution or deadend but I am working with Netlify devs on a solution here netlify/zip-it-and-ship-it#1167 no luck gonna try esbuild setting to see if it resovles!

dthyresson added a commit that referenced this issue Aug 25, 2022
…Netlify CLI (#6261)

* Clairify Netlify CLI and deploy #6260

* Update docs/docs/cli-commands.md

Co-authored-by: Erica Pisani <[email protected]>

* Update docs/docs/deploy/netlify.md

Co-authored-by: Erica Pisani <[email protected]>

* Update docs/docs/tutorial/chapter4/deployment.md

Co-authored-by: Erica Pisani <[email protected]>

* Update docs/docs/cli-commands.md

Co-authored-by: Tobbe Lundberg <[email protected]>

* Update docs/docs/cli-commands.md

Co-authored-by: Tobbe Lundberg <[email protected]>

* Update docs/docs/cli-commands.md

Co-authored-by: Tobbe Lundberg <[email protected]>

* Now in sync with cli-commands.md file changes

Co-authored-by: Erica Pisani <[email protected]>
Co-authored-by: Tobbe Lundberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants