Fix accumulating camera rotation drift

redplant3d · Apr 17, 2024 · 2da160b · 2da160b
1 parent ee1b1dc
commit 2da160b
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/packages/redgeometry-app/src/parts/gpu-cube.ts b/packages/redgeometry-app/src/parts/gpu-cube.ts
@@ -300,8 +300,8 @@ function cameraMoveSystem(world: World): void {
         return;
     }
 
-    const camRot = transform.rotation;
-    const camPos = transform.translation;
+    let camRot = transform.rotation;
+    let camPos = transform.translation;
 
     if (mouse.isPressing(MouseButtons.Mouse3)) {
         let dx = 0;
@@ -316,6 +316,8 @@ function cameraMoveSystem(world: World): void {
 
         camRot.rotateXPre(sens * dy);
         camRot.rotateY(sens * dx);
+
+        camRot = camRot.unit();
     }
 
     let vel = 0.005;
@@ -337,9 +339,12 @@ function cameraMoveSystem(world: World): void {
         v = v.unitOrZero().mul(delta * vel);
         v = camRot.mulVec(v);
 
-        transform.translation = camPos.add(v);
+        camPos = camPos.add(v);
     }
 
+    transform.rotation = camRot;
+    transform.translation = camPos;
+
     world.updateComponent<TransformComponent>(mainCamera, "transform");
 
     const fovRad = fov * (Math.PI / 180);