kgo-repeater: rebuild client on consumer errors #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Give clients helpful names that simplify debugging when a particular worker has an issue. The name shows up in: - kgo-repeater -debug log - kgo-repeater -trace log (franz-go logs) - redpanda server as the client ID Related: redpanda-data/redpanda#5959
If a consumer gets an unrecoverable error (e.g. an unknown_server_error) that leaves the client library in a confused state, we may need to totally tear it down and make a new one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is parked here in case we need it. It was part of debugging for #5959 to eliminate the possibility that the workers might have been okay if they just restarted on errors, but in that issue it turned out that workers were really getting stuck without any actual consume errors.
Some errors might put client in a stuck state where
it needs to be torn down and recreated. These are
liable to be bugs (hence exposing in a counter for
tests to check), but we do not want them to manifest
as members mysteriously hanging: we should drop out
and rebuild the client so that we continue to generate load.