Run make fmt and add it to gha

redpanda-data · Oct 24, 2024 · 307f70f · 307f70f
1 parent f92cf2f
commit 307f70f
Show file tree

Hide file tree

Showing 10 changed files with 15 additions and 3 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -39,6 +39,9 @@ jobs:
     - name: Test
       run: make test
 
+    - name: Fmt
+      run: make fmt && test -z "$(git ls-files --others --modified --exclude-standard)" || { >&2 echo "Unformatted files detected. This can be fixed with 'make fmt'."; exit 1; }
+
   golangci-lint:
     if: ${{ github.repository == 'redpanda-data/connect' || github.event_name != 'schedule' }}
     runs-on: ubuntu-latest

diff --git a/internal/impl/snowflake/output_snowflake_streaming.go b/internal/impl/snowflake/output_snowflake_streaming.go
@@ -17,6 +17,7 @@ import (
 
 	"github.com/redpanda-data/benthos/v4/public/bloblang"
 	"github.com/redpanda-data/benthos/v4/public/service"
+
 	"github.com/redpanda-data/connect/v4/internal/impl/snowflake/streaming"
 )
 

diff --git a/internal/impl/snowflake/streaming/compat_test.go b/internal/impl/snowflake/streaming/compat_test.go
@@ -18,8 +18,9 @@ import (
 	"testing"
 	"time"
 
-	"github.com/redpanda-data/connect/v4/internal/impl/snowflake/streaming/int128"
 	"github.com/stretchr/testify/require"
+
+	"github.com/redpanda-data/connect/v4/internal/impl/snowflake/streaming/int128"
 )
 
 func TestEncryption(t *testing.T) {

diff --git a/internal/impl/snowflake/streaming/integration_test.go b/internal/impl/snowflake/streaming/integration_test.go
@@ -24,9 +24,10 @@ import (
 	"time"
 
 	"github.com/redpanda-data/benthos/v4/public/service"
-	"github.com/redpanda-data/connect/v4/internal/impl/snowflake/streaming"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
+
+	"github.com/redpanda-data/connect/v4/internal/impl/snowflake/streaming"
 )
 
 func msg(s string) *service.Message {

diff --git a/internal/impl/snowflake/streaming/rest.go b/internal/impl/snowflake/streaming/rest.go
@@ -30,6 +30,7 @@ import (
 	"github.com/golang-jwt/jwt"
 	"github.com/google/uuid"
 	"github.com/redpanda-data/benthos/v4/public/service"
+
 	"github.com/redpanda-data/connect/v4/internal/impl/snowflake/streaming/int128"
 	"github.com/redpanda-data/connect/v4/internal/periodic"
 	"github.com/redpanda-data/connect/v4/internal/typed"

diff --git a/internal/impl/snowflake/streaming/schema.go b/internal/impl/snowflake/streaming/schema.go
@@ -18,6 +18,7 @@ import (
 
 	"github.com/dustin/go-humanize"
 	"github.com/parquet-go/parquet-go"
+
 	"github.com/redpanda-data/connect/v4/internal/impl/snowflake/streaming/int128"
 )
 

diff --git a/internal/impl/snowflake/streaming/streaming.go b/internal/impl/snowflake/streaming/streaming.go
@@ -27,6 +27,7 @@ import (
 	"github.com/cenkalti/backoff/v4"
 	"github.com/parquet-go/parquet-go"
 	"github.com/redpanda-data/benthos/v4/public/service"
+
 	"github.com/redpanda-data/connect/v4/internal/periodic"
 	"github.com/redpanda-data/connect/v4/internal/typed"
 )

diff --git a/internal/impl/snowflake/streaming/userdata_converter.go b/internal/impl/snowflake/streaming/userdata_converter.go
@@ -21,6 +21,7 @@ import (
 	"github.com/Jeffail/gabs/v2"
 	"github.com/parquet-go/parquet-go"
 	"github.com/redpanda-data/benthos/v4/public/bloblang"
+
 	"github.com/redpanda-data/connect/v4/internal/impl/snowflake/streaming/int128"
 )
 

diff --git a/internal/impl/snowflake/streaming/userdata_converter_test.go b/internal/impl/snowflake/streaming/userdata_converter_test.go
@@ -17,8 +17,9 @@ import (
 	"time"
 
 	"github.com/parquet-go/parquet-go"
-	"github.com/redpanda-data/connect/v4/internal/impl/snowflake/streaming/int128"
 	"github.com/stretchr/testify/require"
+
+	"github.com/redpanda-data/connect/v4/internal/impl/snowflake/streaming/int128"
 )
 
 type validateTestCase struct {

diff --git a/internal/impl/timeplus/output.go b/internal/impl/timeplus/output.go
@@ -7,6 +7,7 @@ import (
 	"sort"
 
 	"github.com/redpanda-data/benthos/v4/public/service"
+
 	"github.com/redpanda-data/connect/v4/internal/impl/timeplus/http"
 )