Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #379 #380

Merged
merged 2 commits into from
Jun 9, 2022
Merged

Fix for issue #379 #380

merged 2 commits into from
Jun 9, 2022

Conversation

apptaro
Copy link
Contributor

@apptaro apptaro commented Jun 8, 2022

Patch to fix the issue #379

@redouane59
Copy link
Owner

Thanks !

@redouane59
Copy link
Owner

Does it build on your side @apptaro ? Because the check are not OK.

@apptaro
Copy link
Contributor Author

apptaro commented Jun 9, 2022 •
edited
Loading

Hi I made corrections. It should build ok now.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@redouane59 redouane59 merged commit a106516 into redouane59:develop Jun 9, 2022
@redouane59
Copy link
Owner

Perfect, it will be on the next release once the other issues will be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apptaro @redouane59