Remove some TODOs

redis · Aug 18, 2022 · 9c808aa · 9c808aa
1 parent 6ff3f67
commit 9c808aa
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 14 deletions.
diff --git a/test/redis/blocking_commands_test.rb b/test/redis/blocking_commands_test.rb
@@ -46,7 +46,6 @@ def test_brpoplpush_disable_client_timeout
   end
 
   def test_brpoplpush_in_transaction
-    # TODO: redis-client transactions don't support blocking calls.
     results = r.multi do |transaction|
       transaction.brpoplpush('foo', 'bar')
       transaction.brpoplpush('foo', 'bar', timeout: 2)

diff --git a/test/redis/internals_test.rb b/test/redis/internals_test.rb
@@ -155,19 +155,6 @@ def test_retry_pipeline_first_command
     end
   end
 
-  def test_don_t_retry_when_second_read_in_pipeline_raises_econnreset
-    skip("TODO: decide if this is really worth it")
-    close_on_ping([1]) do |redis|
-      assert_raises Redis::ConnectionError do
-        redis.pipelined do |pipeline|
-          pipeline.ping
-          pipeline.ping # Second #read times out
-        end
-      end
-      refute_predicate redis._client, :connected?
-    end
-  end
-
   def close_on_connection(seq, &block)
     @n = 0