Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed default dialect to 2 #3467

Merged
merged 9 commits into from
Jan 9, 2025
Merged

Changed default dialect to 2 #3467

merged 9 commits into from
Jan 9, 2025

Conversation

vladvildanov
Copy link
Collaborator

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

The default DIALECT parameter for Search and AggregationQuery has been changed to 2

@vladvildanov vladvildanov added the breakingchange API or Breaking Change label Dec 26, 2024
uglide
uglide approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@uglide uglide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good. See one suggestion in the inline comment.

redis/commands/search/query.py Outdated
@@ -40,7 +40,7 @@ def __init__(self, query_string: str) -> None:
self._highlight_fields: List = []
self._language: Optional[str] = None
self._expander: Optional[str] = None
self._dialect: Optional[int] = None
self._dialect: int = 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest creating a new file like dialect.py and defining this magic number as a constant there.

@vladvildanov vladvildanov merged commit 7a6b412 into master Jan 9, 2025
33 checks passed
@vladvildanov vladvildanov deleted the vv-default-dialect-change branch January 9, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uglide uglide uglide approved these changes

Assignees
No one assigned
Labels
breakingchange API or Breaking Change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vladvildanov @uglide