Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AttributeError when client.get_default_node() returns None #3458

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bacchuswng
Copy link

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

The default node is sometimes None. It's not obvious from the code how this happens (maybe an Exception that isn't being handled correctly, or a connection-related object is being closed while pipeline execution is still in progress). Regardless, we've observed AttributeError: 'NoneType' object has no attribute 'name' in practice.

Adding this defensive check ensures that we don't run into this issue.

@zs-neo
Copy link
Contributor

zs-neo commented Dec 19, 2024

Can you provide more information? How do you use redis-py? We are also trying related features and want to make sure we don’t encounter the same error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants