Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ts): xtrim threshold accepts string #2828

Draft
wants to merge 32 commits into
base: v5
Choose a base branch
from
Draft

fix(ts): xtrim threshold accepts string #2828

wants to merge 32 commits into from

Conversation

Eomm
Copy link

@Eomm Eomm commented Sep 5, 2024

Description

The XTRIM command accepts a streamId that is a string:

XTRIM foo MINID "1725522294258-0"

Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

jjsimps and others added 30 commits May 16, 2024 10:17
redis#2783)

* shallow copy of this.#options.defaults.socket

* shallow copy of this.#options.defaults.socket

* nit

---------

Co-authored-by: Max Gruenfelder <[email protected]>
Co-authored-by: Leibale Eidelman <[email protected]>
copied from what leibele did for v5
* Support the NOVALUES option of HSCAN

Issue redis#2705

The NOVALUES option instructs HSCAN to only return keys, without their
values. This is materialized as a new command, `hScanNoValues`, given
that the return type is different from the usual return type of `hScan`.
Also a new iterator is provided, `hScanNoValuesIterator`, for the same
reason.

* skip hscan novalues test if redis < 7.4

* Also don't test hscan no values iterator < 7.4

---------

Co-authored-by: Shaya Potter <[email protected]>
* add addscores to aggregate search command

* change `true` to `boolean`

---------

Co-authored-by: Leibale Eidelman <[email protected]>
* add 7.4-rc2 to github action test suite

* Update tests.yml

---------

Co-authored-by: Leibale Eidelman <[email protected]>
* fix: json.mget should be readonly (redis#2807)

* lint
* small refactor per discussion with leibele

* move true type to boolean type

* fix geoshape to support NOINDEX & SORTABLE, clean code

* fix for last commit

---------

Co-authored-by: Leibale Eidelman <[email protected]>
@leibale
Copy link
Contributor

leibale commented Sep 19, 2024

Good catch! Can you please do it for the v5 branch instead? Thanks!

@Eomm Eomm changed the base branch from master to v5 December 2, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants