fix: safety close in AsyncConnectionProvider #2935 #2960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tishun
added
the
status: waiting-for-feedback
Roiocam
changed the title
Roiocam
commented
Aug 30, 2024
| CountDownLatch slowCreate = new CountDownLatch(1); | ||
| CountDownLatch slowShutdown = new CountDownLatch(1); | ||
|
|
||
| // create a provider with a slow connection creation |
There was a problem hiding this comment.
that's means it will create an Sync but hasn't completed yet, even when we need to close provider
| }); | ||
|
|
||
| // add slow shutdown connection first | ||
| SlowCloseFuture slowCloseFuture = new SlowCloseFuture(slowShutdown); |
There was a problem hiding this comment.
use for blocking the iterating.
| CompletableFuture<AsyncCloseable> createFuture = provider.getConnection("slowCreate"); | ||
|
|
||
| // close the connection. | ||
| CompletableFuture<Void> closeFuture = provider.close(); |
There was a problem hiding this comment.
close the provider, the hashmap contains two elements, but only the slowShutdown key Sync will be add it to close futures, because it has been created, but slowCreate didn't(it will add it to futures after creation completed, this path will cause unsafety, which mean IndexOutOfBound or ConcurrentModificationException)
tishun
removed
the
status: waiting-for-feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ConcurrentHashMap didn't guarantee the iterator consistency with entries...
Make sure that:
mvn formatter:formattarget. Don’t submit any formatting related changes.