Initial commit for dual publishing TopologyRefreshEvent to EventBus #2819
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publish TopologyRefreshEvent to event bus #2809
Update: 2024-04-07
Only include interface change to get a sense of direction before larger change.
Some reasoning:
DurationalEvent
to capture the traits of event thats not ephemeral or instantaneous.I didn't reuse the Event interface because most of events that implements it are instantaneous and I don't want them to
carry traits that could indicate anything that's related to duration.
EventRecorder
to explicitly handle dual publishing (recording with recorder and publishing with event bus or only recording). This seems to be the most straight forward and I am also open to creating a new wrapper class for dual publishing only.TopologyRefreshEvent
as I suspect there are many people subscribing to it from EventBus already. I am also open to create new events class dedicated for the start and end for topology refresh operation.Make sure that: