Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: command builder shouldn't be called multiple times #406

Merged
merged 5 commits into from
Nov 17, 2024
Merged

perf: command builder shouldn't be called multiple times #406

merged 5 commits into from
Nov 17, 2024
+147 −41

Conversation

supercaracal
Copy link
Member

@supercaracal supercaracal commented Nov 17, 2024 •
edited
Loading

@supercaracal supercaracal linked an issue Nov 17, 2024 that may be closed by this pull request
CommandBuilder#generate method is called twice by us to waste #405
Closed
@supercaracal supercaracal changed the title perf: command builder should be called once perf: command builder shouldn't be called multiple times Nov 17, 2024
@supercaracal supercaracal marked this pull request as ready for review November 17, 2024 12:47
@supercaracal supercaracal merged commit 5817a0b into redis-rb:master Nov 17, 2024
33 checks passed
@supercaracal supercaracal deleted the perf-cmd-builder-once branch November 17, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CommandBuilder#generate method is called twice by us to waste
1 participant
@supercaracal