Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(RHEL-72798) sd-device: fix validation for devices under /sys/firmware/ in sd_devi… #50

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

lnykryn
Copy link
Member

@lnykryn lnykryn commented Jan 6, 2025

…ce_new_from_subsystem_sysname()

Devices under /sys/firmware/ do not have subsystems. Hence, the validation in sd_device_new_from_subsystem_sysname() -> device_new_from_path_join() always failed.

Fixes a bug introduced by cd7c711 (v257). Fixes #35861.

(cherry picked from commit 3328d1e1816f408e6516c35991a89a8d21fd60b4)

Resolves: RHEL-72798

…ce_new_from_subsystem_sysname()

Devices under /sys/firmware/ do not have subsystems. Hence, the
validation in sd_device_new_from_subsystem_sysname() ->
device_new_from_path_join() always failed.

Fixes a bug introduced by cd7c711 (v257).
Fixes #35861.

(cherry picked from commit 3328d1e1816f408e6516c35991a89a8d21fd60b4)

Resolves: RHEL-72798
@github-actions github-actions bot changed the title sd-device: fix validation for devices under /sys/firmware/ in sd_devi… (RHEL-72798) sd-device: fix validation for devices under /sys/firmware/ in sd_devi… Jan 6, 2025
Copy link

github-actions bot commented Jan 6, 2025

Commit validation

Tracker - RHEL-72798

The following commits meet all requirements

commit upstream
1a9f20b - sd-device: fix validation for devices under /sys/firmware/ in sd_devic… systemd/systemd@3328d1e

Tracker validation

Success

🟢 Tracker RHEL-72798 has set desired product: rhel-10.0
🟢 Tracker RHEL-72798 has set desired component: systemd
🟢 Tracker RHEL-72798 has been approved
🟢 Tracker RHEL-72798 has set severity


Pull Request validation

Success

🟢 CI - All checks have passed
🟢 Review - Reviewed by a member
🟢 Approval - Changes were approved


Auto Merge

Success

🟢 Pull Request is not marked as draft and it's not blocked by dont-merge label
🟢 Pull Request meet requirements, title has correct form
🟢 Pull Request meet requirements, mergeable is true
🟢 Pull Request meet requirements, mergeable_state is clean
🟢 Pull Request has correct target branch main
🟢 Pull Request was merged

Copy link
Member

@dtardon dtardon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate commits that mix bug fixes with cleanup... But LGTM

@github-actions github-actions bot merged commit be5c131 into redhat-plumbers:main Jan 6, 2025
27 checks passed
@jamacku jamacku added this to the RHEL-10.0 milestone Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants