Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(RHEL-30581) fix(github): update format of labeler #81

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

jamacku
Copy link
Member

@jamacku jamacku commented Feb 13, 2024

Since we are using actions/labeler@main, its format changed, displaying the following error with every new PR:

Run actions/labeler@main
The configuration file (path: .github/labeler.yml) was not found locally, fetching via the api
Error: Error: found unexpected type for label 'repository' (should be array of config options)
Error: found unexpected type for label 'repository' (should be array of config options)

(cherry picked from commit de8ac6300d115a05d467dbb6b9a7c2599a2d306f)

@pvalena
Copy link
Contributor

pvalena commented Feb 16, 2024

Thanks! I was wondering why this issue was there ...

@jamacku
Copy link
Member Author

jamacku commented Feb 17, 2024

It's because you are using actions/labeler@main, which is like using Fedora Rawhide. Every commit to the main branch can break your labeling workflow. If you were using v4 in upstream instead, you would not be affected by breaking changes in v5: https://github.com/actions/labeler?tab=readme-ov-file#breaking-changes-in-v5

Overall, it's not a good practice to use the main|master branch. Use version or sha pinning instead:
https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-third-party-actions

@pvalena, this can happen again in the future.

Copy link

github-actions bot commented Jul 17, 2024

Commit validation

Tracker - RHEL-30581

The following commits meet all requirements

commit upstream
a4436f8 - fix(github): update format of labeler dracutdevs/dracut@de8ac63
884943c - ci: fix source-git automation rhel-only

Tracker validation

Failed

🔴 Tracker RHEL-30581 has product rhel-9.5 but desired product is one of Red Hat Enterprise Linux 9,CentOS Stream 9,rhel-9.0.0,rhel-9.0.0.z,rhel-9.2.0,rhel-9.2.0.z,rhel-9.3.0,rhel-9.3.0.z,rhel-9.4.0,rhel-9.4.0.z,rhel-9.5.0,rhel-9.5.0.z,rhel-9.6.0,rhel-9.6.0.z,rhel-9.7.0,rhel-9.7.0.z,rhel-9.8.0,rhel-9.8.0.z,rhel-9.9.0,rhel-9.9.0.z,rhel-9.10.0,rhel-9.10.0.z
🔴 Tracker RHEL-30581 has component dracut but desired component is systemd

Success

🟢 Tracker RHEL-30581 has been approved


Pull Request validation

Failed

🔴 Review - Missing review from a member

Success

🟡 CI - Waived

Since we are using `actions/labeler@main`, its format changed, displaying the
following error with every new PR:

```
Run actions/labeler@main
The configuration file (path: .github/labeler.yml) was not found locally, fetching via the api
Error: Error: found unexpected type for label 'repository' (should be array of config options)
Error: found unexpected type for label 'repository' (should be array of config options)
```

(cherry picked from commit de8ac6300d115a05d467dbb6b9a7c2599a2d306f)

Related: RHEL-30581
@github-actions github-actions bot changed the title fix(github): update format of labeler (RHEL-30581) fix(github): update format of labeler Jul 17, 2024
rhel-only

Related: RHEL-30581
@jamacku
Copy link
Member Author

jamacku commented Jul 17, 2024

@pvalena, this PR should fix PR labeler and source-git automation (to check dracut issues instead of systemd and I have also updated the list of supported releases).

I'll waive CI, since all the changes will be taken into account only after they are merged.

@jamacku jamacku requested a review from pvalena July 17, 2024 13:50
@jamacku jamacku marked this pull request as ready for review July 17, 2024 13:51
@pvalena
Copy link
Contributor

pvalena commented Jul 17, 2024

@pvalena, this PR should fix PR labeler and source-git automation (to check dracut issues instead of systemd and I have also updated the list of supported releases).

I'll waive CI, since all the changes will be taken into account only after they are merged.

Right, LGTM, thanks a lot for looking into this!

@pvalena pvalena merged commit 53ee074 into redhat-plumbers:main Jul 17, 2024
40 of 44 checks passed
@jamacku jamacku deleted the fix-labeler branch July 17, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants