-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: revise last sentence in paragraph about segmentation-fault #391
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two .DS_Store
files that were included here that need to be removed. But once those are removed, the actual update LGTM!
.DS_Store
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This extraneous file needs to be removed (there is also another one inside of supplementary_style_guide)
Hi @bergerhoffer. The files are gone now! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Just needs 2 more approvals @redhat-documentation/ccs-style-council
@CBID2 Many thanks for making so many of the updates that I suggested in that issue, much appreciated! I know you have made the change that I originally suggested (thank you!), but now I think we should also append the sentence "Never use the abbreviation "segfault" as a verb." -- I think that new sentence makes that point more strongly than the text I'd originally suggested. |
You're welcome @bredamc. I think I got rid of that part when I made the PR. |
supplementary_style_guide/glossary_terms_conventions/general_conventions/s.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Breda McColgan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Many thanks for the prompt updates :)
@bredamc, I think this part "when a process tries to access a memory location that it is not allowed to access, or tries to access a memory location in a way that is not allowed" could be improved. It sounds a bit repetitive. |
@CBID2 Many thanks for your suggested update. I actually prefer the original wording because it clarifies that either the location or the access method might be the problem. But I'm not an expert in this area so I'll defer to @bergerhoffer -- she might know who wrote the original text. :) |
Oh in that case @bredamc, that's fine. We can approve (or in this case, you can approve) and merge this for now. |
Hey @bergerhoffer. I made the changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR updates the description on how to use a segmentation fault, ensuring that the description is clear and follows the established style guide.
Issue
Closes number 21 in #147