feat: add extra data with solutionTitle to property completion #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-spacek
changed the title
p-spacek
added a commit
to jigx-com/rh-yaml-language-server
that referenced
this pull request
May 29, 2024
p-spacek
force-pushed
the
feat/add-extra-data-to-property-completion
branch
from
d77d482
to
c5188d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
add data property (with schema title) to property completion items
this extra info can be used later in the client
I tried to implement this inside the YLS, but the types don't correspond with vscode client,
the unfinished implementation is here: 54e817f
I can add this implementation into the YLS later, once the types will be solved
server types vs vscode types
example of usage:
What issues does this PR fix or reference?
Is it tested? How?
unit test