Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(e2e): add conditional policies to the e2e rbac operator instance #2262

Merged

Conversation

Omar-AlJaljuli
Copy link
Contributor

@Omar-AlJaljuli Omar-AlJaljuli commented Jan 27, 2025

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

Description

Add conditional policies to the e2e rbac operator instance

Which issue(s) does this PR fix

RHIDP-5641

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Copy link

openshift-ci bot commented Jan 27, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@Omar-AlJaljuli
Copy link
Contributor Author

/test all

@Omar-AlJaljuli
Copy link
Contributor Author

/test all

1 similar comment
@Omar-AlJaljuli
Copy link
Contributor Author

/test all

@Omar-AlJaljuli Omar-AlJaljuli changed the title [Do not merge] test rbac policy csv with operator chore(e2e): add conditional policies to the e2e rbac operator instance Jan 28, 2025
@Omar-AlJaljuli
Copy link
Contributor Author

/test all

@Omar-AlJaljuli
Copy link
Contributor Author

/test all

@Omar-AlJaljuli
Copy link
Contributor Author

/test all

1 similar comment
@Omar-AlJaljuli
Copy link
Contributor Author

/test all

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
Copy link
Collaborator

@josephca josephca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

openshift-ci bot commented Jan 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josephca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 5ba2f77 into redhat-developer:main Jan 29, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants