Ignore errors that might happen when getting Devfile Registries from …

…the cluster (#6639)

pkg/registry/registry.go

@@ -67,9 +67,11 @@ func (o RegistryClient) GetDevfileRegistries(registryName string) ([]api.Registr
 	if o.kubeClient != nil {
 		clusterRegistries, err := o.kubeClient.GetRegistryList()
 		if err != nil {
-			return nil, err
+			// #6636 : errors should not be blocking
+			klog.V(3).Infof("failed to get Devfile registries from the cluster: %v", err)
+		} else {
+			allRegistries = append(allRegistries, clusterRegistries...)
 		}
-		allRegistries = append(allRegistries, clusterRegistries...)
 	}
 	allRegistries = append(allRegistries, o.preferenceClient.RegistryList()...)
 

pkg/registry/registry_test.go

@@ -125,7 +125,18 @@ OdoSettings:
 				result.EXPECT().GetRegistryList().Return(nil, errors.New("an error"))
 				return result
 			},
-			wantErr: true,
+			want: []api.Registry{
+				{
+					Name:   "CheDevfileRegistry",
+					URL:    "https://che-devfile-registry.openshift.io/",
+					Secure: false,
+				},
+				{
+					Name:   "DefaultDevfileRegistry",
+					URL:    "https://registry.devfile.io",
+					Secure: false,
+				},
+			},
 		},
 	}
 
@@ -139,7 +150,6 @@ OdoSettings:
 			ctrl := gomock.NewController(t)
 
 			prefClient, _ := preference.NewClient(ctx)
-			// TODO(rm3l) Test with both nil and non-nil kubeclient
 			var kc kclient.ClientInterface
 			if tt.kclient != nil {
 				kc = tt.kclient(ctrl)