Add omitempty yaml tag to deprecated log.Wrapper fields #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fishy
force-pushed
the
omit-empty-deprecated-log-wrapper
branch
3 times, most recently
from
4f0d350
to
95c61de
Compare
fishy
requested review from
kylelemons,
konradreiche and
pacejackson
and removed request for
a team
kylelemons
approved these changes
Aug 15, 2024
I just included #659, as otherwise the CI would not run. |
I think the current PR description covered everything that's not in #659? Do you notice anything missing? |
fishy
force-pushed
the
omit-empty-deprecated-log-wrapper
branch
from
95c61de
to
cfb81f7
Compare
kylelemons
approved these changes
Aug 15, 2024
fishy
force-pushed
the
omit-empty-deprecated-log-wrapper
branch
from
a2c7e9e
to
01609be
Compare
kylelemons
approved these changes
Aug 15, 2024
fishy
force-pushed
the
omit-empty-deprecated-log-wrapper
branch
from
01609be
to
a6a4382
Compare
Also implement log.Wrapper.MarshalYAML for nil values. Also add `yaml:"-"` explicitly for config struct fields that's not yaml-unmarshal-able.
fishy
force-pushed
the
omit-empty-deprecated-log-wrapper
branch
from
a6a4382
to
6c818f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also implement log.Wrapper.MarshalYAML for nil values.
Also add
yaml:"-"explicitly for config struct fields that's not yaml-unmarshal-able.