Add support for MinConnections to thriftbp.ClientPool #634
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💸 TL;DR
This adds the ability to specify a minimum number of connections to
thriftbp.ClientPool
andclientpool.ChannelPool
. Having a maintained minimum pool size provides benefits for load balancing which can help even out CPU/RAM utilization on the server side.📜 Details
We can't rely on
requiredInitialClients
(since it can fail startup) and ifbestEffortInitialClients
fails we end up with a partly preallocated pool, this provides a mechanism to maintain the pool size on an ongoing basis.This is accomplished by spinning up an
ensureMinClients
goroutine per pool which will check the total number of connections (active+idle) and open more as needed to keep that amount >= the minimum.It should be non-breaking as the default behaviour is to not have a minimum set and not spin up the
ensureMinClients
goroutine.🧪 Testing Steps / Validation
✅ Checks