Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for enabling clusterwide encryption as day-2 operation #2966

Merged

Conversation

sp98
Copy link
Contributor

@sp98 sp98 commented Jan 15, 2025

On existing ODF clusters, customers can enable clusterwide encryption by enabling spec.Encryption.ClusterWide to true. Rook will destroy the OSDs are recreate them with same OSD ID after enabling encryption.
EPIC - https://issues.redhat.com/browse/RHSTOR-6075

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 15, 2025
Copy link
Contributor

openshift-ci bot commented Jan 15, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@sp98 sp98 force-pushed the enable-encryption-day-2 branch 2 times, most recently from e6e8c14 to 7afd693 Compare January 16, 2025 12:08
@sp98 sp98 marked this pull request as ready for review January 16, 2025 12:09
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 16, 2025
@sp98
Copy link
Contributor Author

sp98 commented Jan 17, 2025

/assign @iamniting

@sp98 sp98 requested a review from iamniting January 20, 2025 05:25
@sp98 sp98 force-pushed the enable-encryption-day-2 branch from 7afd693 to f48e5c6 Compare January 20, 2025 09:56
controllers/storagecluster/cephcluster.go Outdated Show resolved Hide resolved
controllers/storagecluster/cephcluster.go Outdated Show resolved Hide resolved
@sp98 sp98 force-pushed the enable-encryption-day-2 branch from f48e5c6 to b2233d5 Compare January 20, 2025 10:50
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2025
Copy link
Contributor

openshift-ci bot commented Jan 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, sp98

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 28be527 into red-hat-storage:main Jan 20, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants