Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

odf-info: stop owning the odf-info configMap #2959

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

odf-info: stop owning the odf-info configMap #2959

wants to merge 2 commits into from

Conversation

rewantsoni
Copy link
Member

Since odf-info is created in operator namespace, in case of multi- storageCluster, we get a "cross-namespace owner references are disallowed" issue. To address this, stop owning the configMap and watch the configMap from storageCluster reconciler

More info on "cross-namespace owner references are disallowed" here.

Bug: https://issues.redhat.com/browse/DFBUGS-1266

@rewantsoni
Copy link
Member Author

/hold for testing

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 9, 2025
@rewantsoni
odf-info: stop owning the odf-info configMap
ccbefaa 
Since odf-info is created in operator namespace, in case of multi
storageCluster, we get a "cross-namespace owner references are
disallowed" issue. To address this, stop owning the configMap
and watch the configMap from storageCluster reconciler

Signed-off-by: Rewant Soni <[email protected]>
@rewantsoni
deps-update
d6d3102 
Signed-off-by: Rewant Soni <[email protected]>
iamniting
iamniting approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@iamniting iamniting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me, Can you pls test it. Once verified pls remove the hold.

/hold

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, rewantsoni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2025
@rewantsoni
Copy link
Member Author

/cherry-pick release-4.18

@openshift-cherrypick-robot
Copy link

@rewantsoni: once the present PR merges, I will cherry-pick it on top of release-4.18 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamniting iamniting iamniting approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@iamniting iamniting

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rewantsoni @openshift-cherrypick-robot @iamniting