Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add monTimeout param in storagecluster CR #2940

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add monTimeout param in storagecluster CR #2940

wants to merge 1 commit into from
+950 −194

Conversation

OdedViner
Copy link
Contributor

No description provided.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: OdedViner
Once this PR has been reviewed and has the lgtm label, please assign nb-ohad for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@OdedViner OdedViner force-pushed the sc_mon_time_out branch 8 times, most recently from bf387aa to 071ffe5 Compare January 5, 2025 16:43
travisn
travisn requested changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See discussion in https://issues.redhat.com/browse/DFBUGS-565 for a different approach to expose this setting

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 7, 2025
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisn travisn travisn requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@travisn travisn

Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OdedViner @openshift-merge-robot @travisn