Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing the waters for convergence #2936

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

leelavg
Copy link
Contributor

@leelavg leelavg commented Dec 18, 2024

intention of this PR is to have storageclasses and volumesnapshotclasses be working for creation, expansion, deletion of storage in below scenarios and more importantly to reason about what all codepaths need to be changed while starting the actual work as whole design for this effort can't be documented w/o testing the waters!

  1. upgraded internal mode cluster
  2. upgraded provider mode cluster
  3. new install

new content that'll not be part of this PR:

  1. webhook defaulting the params of storageclass
  2. any adapters for UI to call into backend
  3. distribution of storageclasses

existing content that is left out:

  1. external mode
  2. removal of internal storageclasses reconciliation
  3. handling various storage features: nfs, keyrotation, topology/affinity
  4. upstream CI script changes to always install client-op
  5. rdr specifics

Any unknowns on becoming knows will be added to one of above subheads.

Signed-off-by: Leela Venkaiah G <[email protected]>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 18, 2024
Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: leelavg
Once this PR has been reviewed and has the lgtm label, please assign umangachapagain for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leelavg
Copy link
Contributor Author

leelavg commented Dec 18, 2024

testing will follow.

consumer controllers and api server is working as expected and sending
correct info for an upgraded internal mode cluster

Signed-off-by: Leela Venkaiah G <[email protected]>
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants