Nim work for 2.16 #379
Merged
Nim work for 2.16 #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: added ability to deploy more than one NIM model. (#3453) * feat: added ability to deploy more than one NIM model. Signed-off-by: Olga Lavtar <[email protected]> * feat: refactored NIM related logic to nimUtils Signed-off-by: Olga Lavtar <[email protected]> * feat: changes to the error handling Signed-off-by: Olga Lavtar <[email protected]> * feat: changes to the error handling Signed-off-by: Olga Lavtar <[email protected]> * feat: changes .some for .forEach Signed-off-by: Olga Lavtar <[email protected]> * feat: deleting secrets fix Signed-off-by: Olga Lavtar <[email protected]> * feat: deploying the same model pvc fix Signed-off-by: Olga Lavtar <[email protected]> * feat: added a unit test for getNIMResourcesToDelete Signed-off-by: Olga Lavtar <[email protected]> * feat: will add a unit test for getNIMResourcesToDelete later Signed-off-by: Olga Lavtar <[email protected]> --------- Signed-off-by: Olga Lavtar <[email protected]> * feat: Modify NIM enablement process (#3455) * Modify NIM enablement process * Clean up code and remove unnecessary manifests * Add logic to check the conditions of the odh-nim-account CR * Added more check for enabled integration apps * If failed to fetch integration app status, should show error on the related tile in the enable application page, should not remove the tile * check integration app status in explore application page * Fix lint issue * Fix lint issue * add annotations to the secret and the account CR * Update backend/src/routes/api/integrations/nim/index.ts Co-authored-by: Andrew Ballantyne <[email protected]> * Update backend/src/routes/api/components/list.ts Co-authored-by: Andrew Ballantyne <[email protected]> * clean up * feat: listing all NIM accounts in the namespace, returning the first one. Signed-off-by: Olga Lavtar <[email protected]> * Avoid mutating object in useWatchIntegrationComponents * Clean up * feat: added logic for displaying the tile correctly Signed-off-by: Olga Lavtar <[email protected]> * feat: changes for enabling Signed-off-by: Olga Lavtar <[email protected]> * feat: updated mock component with the new properties. Signed-off-by: Olga Lavtar <[email protected]> * feat: addressed PR comments with updates and improvements Signed-off-by: Olga Lavtar <[email protected]> * feat: backend bug fix Signed-off-by: Olga Lavtar <[email protected]> * feat: Missed change from previous commit Signed-off-by: Olga Lavtar <[email protected]> * feat: fix for the enabled page and enabled.cy.ts Signed-off-by: Olga Lavtar <[email protected]> --------- Signed-off-by: Olga Lavtar <[email protected]> Co-authored-by: Andrew Ballantyne <[email protected]> Co-authored-by: Olga Lavtar <[email protected]> * Fix NIM selection issue (#3482) * Fix NIM selection issue * Switch back to using a numerical value --------- Signed-off-by: Olga Lavtar <[email protected]> Co-authored-by: olavtar <[email protected]> Co-authored-by: yu zhao <[email protected]> Co-authored-by: Olga Lavtar <[email protected]>
andrewballantyne
changed the title
andrewballantyne
changed the title
Gkrumbach07
approved these changes
Nov 15, 2024
* Improve error message in log * Fix the Service Account permissions
|
andrewballantyne
merged commit f2a6640
into
red-hat-data-services:rhoai-2.16
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last of the NIM work.
Update 2024-11-15, 3:10pm ET: Seems there are some problems with the current makeshift deployment on the NIM cluster -- not sure this code will work on a RHOAI cluster. (thread)
Update 2024-11-15, 4:35pm ET: A fix is found for our issue -- looking to get it into main & then our release branch which will update this PR.
Update 2024-11-15, 5:40pm ET: Last commit has merged successfully through the Pipeline -- waiting on one last CI run and a merge