Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable connection types #377

Closed
wants to merge 2 commits into from
Closed

enable connection types #377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c575d1f
enable connection types by default (#3452)
christianvogt Nov 12, 2024
4066b69
Check and use response of connection saving (#3462)
emilys314 Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/src/utils/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export const blankDashboardCR: DashboardConfig = {
disableDistributedWorkloads: false,
disableModelRegistry: false,
disableServingRuntimeParams: false,
disableConnectionTypes: true,
disableConnectionTypes: false,
disableStorageClasses: false,
disableNIMModelServing: true,
},
Expand Down
10 changes: 4 additions & 6 deletions docs/dashboard-config.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,13 @@ The following are a list of features that are supported, along with there defaul
| disableKServeMetrics | false | Disables the ability to see KServe Metrics. |
| disableModelMesh | false | Disables the ability to select ModelMesh as a Serving Platform. |
| disableAcceleratorProfiles | false | Disables Accelerator profiles from the Admin Panel. |
| disableTrustyBiasMetrics | false | Disables Model Bias tab from Model Serving metrics. |
| disableTrustyBiasMetrics | false | Disables Model Bias tab from Model Serving metrics. |
| disablePerformanceMetrics | false | Disables Endpoint Performance tab from Model Serving metrics. |
| disableDistributedWorkloads | false | Disables Distributed Workload Metrics from the dashboard. |
| disableModelRegistry | false | Disables Model Registry from the dashboard. |
| disableServingRuntimeParams | false | Disables Serving Runtime params from the dashboard. |
| disableConnectionTypes | true | Disables creating custom data connection types from the dashboard. |
| disableStorageClasses | false | Disables storage classes settings nav item from the dashboard. |
| disableNIMModelServing | true | Disables components of NIM Model UI from the dashboard.
| disableServingRuntimeParams | false | Disables Serving Runtime params from the dashboard. |
| disableStorageClasses | false | Disables storage classes settings nav item from the dashboard. |
| disableNIMModelServing | true | Disables components of NIM Model UI from the dashboard. |

## Defaults

Expand Down Expand Up @@ -66,7 +65,6 @@ spec:
disableTrustyBiasMetrics: false
disablePerformanceMetrics: false
disableDistributedWorkloads: false
disableConnectionTypes: false
disableStorageClasses: false
disableNIMModelServing: true
```
Expand Down
20 changes: 16 additions & 4 deletions frontend/src/pages/projects/screens/spawner/connections/ConnectionsFormSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import { Connection, ConnectionTypeConfigMapObj } from '~/concepts/connectionTyp
import {
filterEnabledConnectionTypes,
getConnectionTypeDisplayName,
isConnection,
} from '~/concepts/connectionTypes/utils';
import { useWatchConnectionTypes } from '~/utilities/useWatchConnectionTypes';
import { useNotebooksStates } from '~/pages/projects/notebook/useNotebooksStates';
Expand Down Expand Up @@ -264,12 +265,23 @@ export const ConnectionsFormSection: React.FC<Props> = ({
refreshProjectConnections();
}
}}
onSubmit={(connection: Connection) => {
onSubmit={async (connection: Connection) => {
if (manageConnectionModal.isEdit) {
return replaceSecret(connection);
const response = await replaceSecret(connection);
if (isConnection(response)) {
setSelectedConnections(
selectedConnections.map((c) =>
c.metadata.name === response.metadata.name ? response : c,
),
);
}
return response;
}
const response = await createSecret(connection);
if (isConnection(response)) {
setSelectedConnections([...selectedConnections, response]);
}
setSelectedConnections([...selectedConnections, connection]);
return createSecret(connection);
return response;
}}
isEdit={manageConnectionModal.isEdit}
/>
Expand Down
2 changes: 0 additions & 2 deletions manifests/common/crd/odhdashboardconfigs.opendatahub.io.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,6 @@ spec:
type: boolean
disableServingRuntimeParams:
type: boolean
disableConnectionTypes:
type: boolean
disableStorageClasses:
type: boolean
disableNIMModelServing:
Expand Down
1 change: 0 additions & 1 deletion manifests/rhoai/shared/odhdashboardconfig/odhdashboardconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ spec:
disableDistributedWorkloads: false
disableModelRegistry: false
disableServingRuntimeParams: false
disableConnectionTypes: true
disableStorageClasses: false
disableNIMModelServing: true
groupsConfig:
Expand Down